[PATCH 06 of 15] speedy: custom wire protocol

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Dec 14 10:37:21 CST 2012


(Tomasz, we prefer bottom-posting on this list to keep the conversation readable in-order. Response below, with quoting damage fixed up.)

On Dec 14, 2012, at 9:31 AM, Augie Fackler wrote:

> On Dec 13, 2012, at 3:34 PM, Bryan O'Sullivan <bos at serpentine.com> wrote:
> 
>> On Dec 13, 2012, at 1:23 AM, Tomasz Kłeczek wrote:
>> 
>>> On Wed, Dec 12, 2012 at 7:30 PM, Augie Fackler <raf at durin42.com> wrote:
>>> 
>>> I'm also a /little/ weirded out by the lack of a version (or capability) handshake in the protocol, but perhaps it fits within YAGNI.
>> 
>> I thought that adding such mechanisms at this point would be an overkill..
>> 
>> It might be right now, but almost every time we have not had such a
>> capability, we've regretted it and had to retrofit it after a few months. I
>> don't think you should do it immediately, but we'll need to add this before
>> this sees any real use.
> 
> Fair enough, but in that case we should file a bug that the protocol is incomplete so we fix it before shipping a release with the weaker protocol.

Indeed. Now is the time to add a capability handshake, if we think there's any remotely possible way that one will be needed in the future (and as Bryan points out, it invariably turns out to be).

Did you pursue the idea of re-using the command server protocol any further?

My other overarching question is, who is signing up to maintain this new in-tree extension for the long haul?

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list