[PATCH 3 of 5 V2] ancestor: add a class to generate ancestors lazily
Kevin Bullock
kbullock+mercurial at ringworld.org
Fri Dec 14 22:26:32 CST 2012
On 14 Dec 2012, at 7:25 PM, Siddharth Agarwal wrote:
> On 12/14/2012 04:13 PM, Siddharth Agarwal wrote:
>> +class lazyancestorset(object):
>> + def __init__(self, repo, revs, increvs, stoprev=0):
>
> I just realized Kevin asked me to pass in a changelog here, and I passed in a repo instead. Passing in repos seems to be a bit more common in general, but either way's fine with me.
>
> The docstring refers to pfunc instead of repo -- I've fixed that locally.
I'd lean toward passing in the changelog directly, but I'll also defer to those who've been in this codebase longer than I have. Others have opinions?
If others are cool with this, I'd take a pull request with the docstring fixed up and changing repo -> changelog, instead of having to patchbomb the list again.
pacem in terris / мир / शान्ति / سَلاَم / 平和
Kevin R. Bullock
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121214/6f514ece/attachment.html>
More information about the Mercurial-devel
mailing list