[PATCH 01 of 24] copies: make the loss in _backwardcopies more stable

Kevin Bullock kbullock+mercurial at ringworld.org
Sun Dec 16 22:57:20 CST 2012


On 16 Dec 2012, at 4:33 PM, Mads Kiilerich wrote:

> # HG changeset patch
> # User Mads Kiilerich <mads at kiilerich.com>
> # Date 1355687455 -3600
> # Node ID 36ef75411e38e3cc4b60198ec20750b87b0a7545
> # Parent  8c9a52492d426741ab24392d49f44a1d4f23613e
> copies: make the loss in _backwardcopies more stable
> 
> A couple of tests shows slightly more correct output. That is pure coincidence.
> 
> diff --git a/mercurial/copies.py b/mercurial/copies.py
> --- a/mercurial/copies.py
> +++ b/mercurial/copies.py
> @@ -150,7 +150,7 @@
>     # in particular, we find renames better than copies
>     f = _forwardcopies(b, a)
>     r = {}
> -    for k, v in f.iteritems():
> +    for k, v in sorted(f.iteritems()):

Right out of the gate here, we've got some potentially visible performance-impacting changes in this series. Can we see some numbers at least on the patches (like this one) that have this possibility?

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list