[Bug 3736] New: convert is creating malformed .hgtags files

[bugzilla-daemon at bz.selenic.com]

http://bz.selenic.com/show_bug.cgi?id=3736

          Priority: normal
            Bug ID: 3736
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: convert is creating malformed .hgtags files
          Severity: bug
    Classification: Unclassified
                OS: Linux
          Reporter: john.peacock at messagesystems.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.4.1
         Component: convert
           Product: Mercurial

Converting an existing Mercurial repo using branchmap to rename branches,
filemap to exclude a subtree, and splicemap to correct previous bad conversion
artifacts (from a prior Subversion conversion), I get malformed .hgtags on some
branches:

...
.hgtags at 0212c11dc4e6, line 111: node 'SKIP' is not well formed
.hgtags at 0212c11dc4e6, line 195: node 'SKIP' is not well formed
.hgtags at 602e7db05584, line 93: node 'SKIP' is not well formed
.hgtags at 602e7db05584, line 177: node 'SKIP' is not well formed
.hgtags at d5f9f399d9f1, line 111: node 'SKIP' is not well formed
.hgtags at d5f9f399d9f1, line 195: node 'SKIP' is not well formed
.hgtags at b30f58db3a5d, line 111: node 'SKIP' is not well formed
.hgtags at b30f58db3a5d, line 195: node 'SKIP' is not well formed
...

The ConvertExtensionImplementation wiki page states:

>Having finished copying commits, the convert method updates the tags in the >destination repository. It asks the source for its dictionary of tags, then >filters each tagged commit's revision identifier through the revision map >(skipping any commit that is not in the map or is mapped to SKIPREV). 

but this is clearly not happening correctly.  If I update to one of those
revisions, I do indeed see malformed .hgtag lines:

>$ fgrep SKIP .hgtags 
>SKIP mc3.3.1.build1
>SKIP 2.2.2.35-2

The source repository does not contain SKIP lines in .hgtags FWIW.

-- 
You are receiving this mail because:
You are on the CC list for the bug.