[PATCH 20 of 24] convert: process splicemap in sorted order

Mads Kiilerich mads at kiilerich.com
Mon Dec 17 19:59:48 CST 2012


Bryan O'Sullivan wrote, On 12/17/2012 10:09 PM:
> On Sun, Dec 16, 2012 at 2:34 PM, Mads Kiilerich <mads at kiilerich.com 
> <mailto:mads at kiilerich.com>> wrote:
>
>     convert: process splicemap in sorted order
>
>
> This doesn't have any visible consequences?

Correct, not with the default hash seed.

Some tests (test-splicemap.t IIRC) would sometimes fail when running 
with random seed - either because of different output ordering or 
because of assumptions in the test code.

That is actually the case for most of the patches in this series. 
Enumerating the failures I have seen and how they were fixed is not 
feasible.

/Mads



More information about the Mercurial-devel mailing list