[PATCH 4 of 4 V3 part 2] rebase: use lazy ancestor membership testing

[Pierre-Yves David]

On Mon, Dec 17, 2012 at 09:30:13PM -0800, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1355806281 28800
> # Node ID 4cda1a1e5675bc46ed4e878170c2ed26e783f769
> # Parent  952ec71894acfbd8ff7f9f831ce6a6d1060e5ccc
> rebase: use lazy ancestor membership testing
> 
> For a repository with over 400,000 commits, rebasing one revision near tip,
> this avoids one walk up the DAG, speeding the operation up by around 0.8
> seconds.

series looks good to me except minor comment on patch1. The code seems to have never ran too. Did you ran the test suite ?


-- 
Pierre-Yves David

http://www.logilab.fr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121218/b8d98267/attachment.pgp>