[PATCH 2 of 4 V3 part 2] ancestor: add lazy membership testing to lazyancestors

[Kevin Bullock]

On Dec 18, 2012, at 12:02 PM, Siddharth Agarwal wrote:

> On 12/18/2012 08:43 AM, Kevin Bullock wrote:
>> Looks good, but some comments below. I don't see any obvious code paths that would suffer from the latter case, do you have a sense of this? 
> 
> Well, I guess you could hit it if you're e.g. rebasing from tip to 0, but then you have bigger problems. In general we're almost always better off.
> 
>> I'm uneasy about this change being included in this patch. It should at least be referenced in the commit message, if not moved to a subsequent patch. 
> 
> It is referenced already in the commit message, isn't it? That's where the perf numbers come from.

Only very indirectly, by the inclusion of the numbers. It says nothing explicitly about the code change.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock