Appending the subrepo path to subrepo push error messages

Angel Ezquerra angel.ezquerra at gmail.com
Wed Dec 19 01:25:41 CST 2012


On Wed, Dec 19, 2012 at 1:47 AM, Matt Mackall <mpm at selenic.com> wrote:
> On Fri, 2012-12-14 at 09:37 +0100, Angel Ezquerra wrote:
>
>> I got a simple patch that I'll send in a while which implements this change.
>
> I'd rather see an unpolished patch than discuss it in the abstract.

OK, I'll take that into account in the future.

I don't know if you saw that I did send my unpolished patch a bit
later. A few people reviewed it and we have been discussing it since
then. Several iterations later the latest version of the patch is:

http://mercurial.markmail.org/message/b376m4yqnrvch2dt?q=list:com%2Eselenic%2Emercurial-devel&page=2

The non-git, non-svn tests pass on Windows and according to Matt
Harbison the whole test suite passes cleanly on Linux.

There are two issues remaining AFAIK:

1. I use a decorator to "handle" subrepo exceptions. I decorated most
public subrepo methods. We have been discussing whether the patch
should be a little more targeted and only decorate some key methods.

2. The way I catch and re-raise the subrepo exceptions seems to cut
the stack trace. Matt Harbison suggested doing something about it on a
separate patch.

Cheers,

Angel


More information about the Mercurial-devel mailing list