I'm having trouble reviewing patches via email

Kevin Bullock kbullock+mercurial at ringworld.org
Thu Dec 20 15:26:51 CST 2012


On Dec 20, 2012, at 3:04 PM, Yann E. MORIN wrote:

> Bryan, Kevin, All,
> 
> On Thursday 20 December 2012 Kevin Bullock wrote:
>> On Dec 20, 2012, at 2:03 PM, Bryan O'Sullivan wrote:
>> 
>>> I'm trying my best to review patches from people on a fairly regular
>>> basis, and I'm having (what feels to me like) an increasing amount
>>> of difficulty keeping up with them via email.
> [--SNIP--]
>>> Am I alone in feeling like the current process isn't serving me well?
>> 
>> It's not ideal. We've discussed implementing a review tool before[1][2],
>> the major blockers being 1) unavailability of good open source tools,
>> and 2) consensus on what the improved workflow should look like given
>> Matt's and others' constraints.
>> 
>> [1]: http://mercurial.markmail.org/thread/5maahid2bbx7d2vr
>> [2]: http://mercurial.selenic.com/wiki/ImprovingCollaboration
> 
> Have you guys had a look at patchwork?
>    http://jk.ozlabs.org/projects/patchwork/    (project page)
>    http://patchwork.ozlabs.org/                (some patchworks)
> 
> In case you don't know Patchwork, it works by listening to a mailing-list
> for patches, stores tehm, and makes them available on a web UI *and* via
> XMLRPC. There is a CLI client for the XMLRPC, to (basically) list and get
> patches.

Thanks for this. A couple questions:

Does it support commenting _inline_ on patches? From what I can see it separates the comments from the patch itself.

Does it support marking a series of patches as a follow-up that supersedes another series?

I also see that it doesn't (yet) support entering comments on the web interface to be sent to the list.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list