[PATCH 1 of 2 [RESEND][V2]] hgweb: add (Atom) subscribe link to the main paper template pages

Matt Mackall mpm at selenic.com
Thu Dec 20 16:34:23 CST 2012


On Thu, 2012-12-20 at 22:26 +0100, Angel Ezquerra wrote:
> On Thu, Dec 20, 2012 at 8:51 PM, Matt Mackall <mpm at selenic.com> wrote:
> > On Thu, 2012-12-20 at 19:25 +0100, Angel Ezquerra wrote:
> >> # HG changeset patch
> >> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> >> # Date 1354578089 -3600
> >> # Node ID 5a516a9dd2b5367c1537180ec207bc0688235c11
> >> # Parent  8ceabb34f1cb5469b7dd6b2d7b1ce4727d719e65
> >> hgweb: add (Atom) subscribe link to the main paper template pages
> >>
> >> The subscribe link is found at the bottom of the navigation sidebar.
> >> This uses a free icon from http://feedicons.com.
> >
> > I think we should drop the 'subscribe' bit or move it to alt-text.
> 
> I will send a patch that removes the subscribe text and sets the title
> of the link to "subscribe to atom feed". Personally I kind of liked it
> a little bit better with the "subscribe" text, but it does not look
> bad without it either.
> 
> > Also,
> > looks like you missed at least the filelog page.
> 
> Since the feeds are now "page specific", I decided to leave the feed
> link out of those pages that do not have a "page specific" feed. In
> particular, I purposely left the link out of the following pages:
> changeset, error, filelog, help, helptopics, notfound and search.

Except filelog DOES have such a feed, hence my repeating myself. Here's
an example:

http://www.selenic.com/hg/atom-log/tip/tests/test-pathencode.py

The help and helptopics are apparently cut-and-paste nonsense that no
one noticed (though I noticed them about an hour ago) as they link to
the tags feed. I've queued a patch to drop 'em.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list