checkrequireslfiles causes very slow push with large repo store

[olivier.trempe at nobelbiocare.com]

Hello,

Our repo store contains 22659 entries. Pushes to remo repo are very slow 
and I narrowed it down to this method:

C:\Python27\Lib\site-packages\hgext\largefiles\reposetup.py:reposetup.checkrequireslfiles()

If your repo doesn't require largefiles, this method builds a list by 
walking the repo store:

util.any(lfutil.shortname+'/' in f[0] for f in repo.store.datafiles())

and it takes ~35 seconds for 22659 entries.

Currently, our workaround is to add "largefiles" to our .hg/requires file 
so it bypasses this list generation.

Did someone else ever experienced such slow push with repos having a large 
store? Could it be improved?

Should I submit this to http://bz.selenic.com?

Thanks

Olivier Trempe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20121221/0e3a9ed9/attachment.html>