[PATCH 1 of 4 stable] largefiles: introduce basic debugstate --large functionality

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Dec 21 13:10:38 CST 2012


On Dec 21, 2012, at 12:56 PM, Mads Kiilerich wrote:

> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1356115949 -3600
> # Branch stable
> # Node ID 7ccb2671617299c81b9ed9f38e3debc7231ebfc4
> # Parent  777084ac84167e3bdea45b5c00de1106cca36eef
> largefiles: introduce basic debugstate --large functionality
> 
> Very useful for debugging largefiles "performance" issues.

+1 on the general direction.

> The added test exposes an issue that will be solved next.

So the test result in the patch is incorrect? Or it's correct but too slow?

> diff --git a/tests/test-largefiles.t b/tests/test-largefiles.t
> --- a/tests/test-largefiles.t
> +++ b/tests/test-largefiles.t
> @@ -17,8 +17,8 @@
>> EOF
> 
> Create the repo with a couple of revisions of both large and normal
> -files, testing that status correctly shows largefiles and that summary output
> -is correct.
> +files, testing that status correctly shows largefiles and and updates
> +dirstate and that summary output is correct.

Big long run-on sentence, and a doubled 'and' ---------- ^^^^^^^

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list