[PATCH 04 of 10 V2] branchmap: takes filtered revision in account for cache calculation

Augie Fackler raf at durin42.com
Mon Dec 31 17:41:01 CST 2012


On Dec 28, 2012, at 12:44 PM, Dave S <snidely.too at gmail.com> wrote:

> On Thu, Dec 27, 2012 at 4:55 PM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>> 
>> On 26 déc. 2012, at 23:25, Dave S wrote:
> 
>>> "build a cache [...] and then return the hash of the cache to use when ..."
>>> 
>>> My current thinking, such as it is, is that being explicit about the
>>> relationship of the hash to the cache is valuable.
>> 
>> You got me totally confused here :-(
>> 
>> Whats wrong? what do you suggest as an alternative ?
> 
> That was my alternative, but I'm satisfied with your taking Kevin's
> suggestion.
> 
> There is still a small concern about "distinct", as I previously
> mentioned.  Do you mean "distinguish" (verb) or "distinct signature"
> (noun) ?

I'm going to stop reviewing this series here, since my MUA is totally failing to thread this and I can't find the conversation with Kevin. Pierre-Yves, can you resend patches 4:tip of this series when you're ready for re-review?

AF

> 
> /dps
> 
> -- 
> test signature -- please apply at front gate on Tuesdays only.



More information about the Mercurial-devel mailing list