expectations from the community

[Patrick Mézard]

Le 07/02/12 11:15, Andrey Somov a écrit :
> 
> 
> On Tue, Feb 7, 2012 at 10:46 AM, Patrick Mézard <patrick at mezard.eu
> <mailto:patrick at mezard.eu>> wrote:
> 
> 
> Can you be more specific? Are you talking about this patch:
> 
> [PATCH hglib] merge and resolve return boolean instead of raising an
> exception 
> http://selenic.com/pipermail/mercurial-devel/2012-January/037664.html
>
>  which Idan commented afterwards?
> 
> 
> It is not the only one.  I totally agree with the review, but the
> question is general: why does anyone spend time on a review if it
> would be quicker and more efficient just to change it and apply to
> the code base ?

Because it is a terribly *boring* and *ungrateful* job.

Keep in mind that most of us are not being paid to do this. So when you receive an half baked patch on a topic you can handle yourself, what do you do:
1- Take the patch, try to edit it, fix all the naming issues, incorrect whitespaces, portability issues, and add tests?
2- Look at the patch to see if the OP was right on track and fix it *your way*, thanking the OP for reporting the issue?

Unless [1] is really about fixing a couple of whitespaces or a commit message (2mn work), I do [2] because I can hardly stand [1] *when I am being paid to do it*.

Finally, reading Idan review:

  http://selenic.com/pipermail/mercurial-devel/2012-January/037663.html

I would say you seem to know your way in python, you write tests and apparently your fix is correct. It is all about commit message formatting and separating concerns. With little effort you can probably get your patch acked and pushed unchanged. So don't blame us trying to make you take this step and turn into a contributor :-)

--
Patrick Mézard