expectations from the community

Benoit Boissinot bboissin at gmail.com
Tue Feb 7 07:20:35 CST 2012


On Tue, Feb 7, 2012 at 2:17 PM, Andrey Somov <py4fun at gmail.com> wrote:

> On Tue, Feb 7, 2012 at 12:26 PM, Patrick Mézard <patrick at mezard.eu> wrote:
>
>>
>> Finally, reading Idan review:
>>
>>  http://selenic.com/pipermail/mercurial-devel/2012-January/037663.html
>>
>> I would say you seem to know your way in python, you write tests and
>> apparently your fix is correct. It is all about commit message formatting
>> and separating concerns. With little effort you can probably get your patch
>> acked and pushed unchanged. So don't blame us trying to make you take this
>> step and turn into a contributor :-)
>>
>
>
> My question is answered. I now clearly see the expectations from the
> community. There are 2 options for a reporter:
>
> 1) do not send any code at all
> 2) if you send code, the code must meet all the quality criteria to be
> included in the code base. The reporter must have enough stamina to push
> the changes until they are accepted
>

Or as stated by Patrick and Dirkjan:
3) Open an issue, paste the patch as a guidance for how it could be fixed.
Let the community provide the patch that will be applied.

Cheers,

Benoit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120207/dbf310c9/attachment.html>


More information about the Mercurial-devel mailing list