[PATCH 1 of 8 STABLE RFC] largefiles: performance improvement for bypass route choice

[FUJIWARA Katsunori]

Thank you for your comments, Matt.

At Fri, 17 Feb 2012 13:58:01 -0600,
Matt Mackall wrote:
> 
> On Sat, 2012-02-18 at 01:07 +0900, FUJIWARA Katsunori wrote:
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1329494572 -32400
> > # Branch stable
> > # Node ID be820a2353e7b3e9af8a59b050cd7bf8b1e38490
> > # Parent  0e0060bf2f440d5cc33e5f36d99868a5380debd4
> > largefiles: performance improvement for bypass route choice
> 
> > +                def hasstandin(f):
> > +                    return os.path.lexists(repo.wjoin(lfutil.standin(f)))
> 
> I frankly find the terminology that largefiles uses confusing. This
> would be better as "islargefile", no?

May be, yes. I'm wondering just whether 'islarge"file"' or same kind
name suits with the function which accepts 'directory pattern' or not.

> Is this really the most efficient way to do this? Can't we look for the
> standin in the dirstate rather than going to the filesystem?

Sorry, this patch series is not well arranged yet, because I gave
priority to share whole bug information I know around "hg status" with
largefiles. And your right.

Patch #6 of this series replace accessing to filesystem with
'dirstate.dirs()'.

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp