[PATCH 3 of 3 STABLE] largefiles: respect store.createmode and avoid extra file copy

Martin Geisler mg at lazybytes.net
Fri Feb 24 00:40:21 CST 2012


Matt Mackall <mpm at selenic.com> writes:

> On Thu, 2012-02-23 at 14:41 +0100, Martin Geisler wrote:
>> # HG changeset patch
>> # User Martin Geisler <mg at aragost.com>
>> # Date 1330000630 -3600
>> # Branch stable
>> # Node ID 1b2b42e866bec02325324749a87c5eb056b5986d
>> # Parent  9b072a5f8f9284930a0441e0399e7cf2cf60e502
>> largefiles: respect store.createmode and avoid extra file copy
>
> These are queued, thanks.

Sounds good!

> For the default branch, we probably want to use an opener object with
> the mode built in.

Yes, I fully agree that an opener should be used. It's frankly as if the
largefiles code doesn't know about a lot of the common idioms we use in
the rest of the code (atomictempfile, createmode, openers).

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120224/acc6d3df/attachment.pgp>


More information about the Mercurial-devel mailing list