[PATCH 00 of 19 STABLE] largefiles: fix bugs of "hg status"

Greg Ward greg at gerg.ca
Mon Feb 27 19:38:54 CST 2012

On 27 February 2012, FUJIWARA Katsunori said:
> this patch series fixes bugs of "hg status" with largefiles extension.
> many of patches in this series are refactoring ones as preparation for
> bugfix in #7, #10, #12, #14, #16, #18, and #19.

I've looked over the first couple of patches, up to #7. The big
question: *which* bugs are you fixing? Are these bugs already in
Mercurial's issue tracker? If so, you should put " (issueXXXX)" in the
commit message. If not, the commit message should clearly explain what
the bug is. From patch #7, I don't understand what's broken in the
current code or how you fixed it. A clearer commit message would help.
A test case would help even more.

Also, refactoring is generally frowned upon in the stable branch. If
the bugs in question cannot be fixed without refactoring, so be it:
the fixes will just have to wait for Mercurial 2.2. But if it's
possible to fix on stable and refactor on default, that increases the
chance of your fixes getting to users sooner (e.g. 2.1.1).

Greg Ward                                http://www.gerg.ca/
Very few profundities can be expressed in less than 80 characters.

More information about the Mercurial-devel mailing list