[PATCH 00 of 19 STABLE] largefiles: fix bugs of "hg status"

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Tue Feb 28 01:32:58 CST 2012

At Mon, 27 Feb 2012 20:38:54 -0500,
Greg Ward wrote:
> On 27 February 2012, FUJIWARA Katsunori said:
> > this patch series fixes bugs of "hg status" with largefiles extension.
> > 
> > many of patches in this series are refactoring ones as preparation for
> > bugfix in #7, #10, #12, #14, #16, #18, and #19.
> I've looked over the first couple of patches, up to #7. The big
> question: *which* bugs are you fixing? Are these bugs already in
> Mercurial's issue tracker? If so, you should put " (issueXXXX)" in the
> commit message. If not, the commit message should clearly explain what
> the bug is. From patch #7, I don't understand what's broken in the
> current code or how you fixed it. A clearer commit message would help.
> A test case would help even more.
> Also, refactoring is generally frowned upon in the stable branch. If
> the bugs in question cannot be fixed without refactoring, so be it:
> the fixes will just have to wait for Mercurial 2.2. But if it's
> possible to fix on stable and refactor on default, that increases the
> chance of your fixes getting to users sooner (e.g. 2.1.1).

Thank you for reading patches and your comments, Greg.

I think refactorings are still needed to simplify bug fix patches.

So, I'll try to re-fine patches themselves, description of them and
test code, and post them for 'default'.

[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp

More information about the Mercurial-devel mailing list