[PATCH] largefiles: display remote errors from putlfile (issue3123) (issue3149)

Kevin Gessner kevin at fogcreek.com
Thu Jan 5 09:27:15 CST 2012


On Wed, Jan 4, 2012 at 7:32 PM, Mads Kiilerich <mads at kiilerich.com> wrote:

> Kevin Gessner wrote, On 01/04/2012 08:43 PM:
>
>  --- a/tests/test-largefiles.t
>> +++ b/tests/test-largefiles.t
>> @@ -824,6 +824,20 @@
>>    [255]
>>    $ cd ..
>>
>> +putlfile errors are shown (issue3123)
>> +  $ echo corruption>  ~/.cache/largefiles/**
>> 4cdac4d8b084d0b599525cf732437f**b337d422a8
>>
>
> Ok, run-tests do set $HOME to $TESTTMP, so I guess the ~ path expands
> correctly ... at least on posix without XDG_CACHE_HOME. But it all seems a
> bit fragile - have you tested it on OS/X?
>
> Wouldn't it be better and more stable to use the (untested and
> undocumented!) usercache config setting throughout the test?


You're very right -- this fails on OS X. Thanks.


>  +  $ hg init empty
>> +  $ hg serve -R empty -d -p $HGPORT1 --pid-file ../hg.pid \
>> +>    --config 'web.allow_push=*' --config web.push_ssl=False
>> +  $ cat hg.pid>>  $DAEMON_PIDS
>>
>
> The different hg.pid paths looks like a cut'n'paste error.


Indeed. Resending.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120105/09881cae/attachment.html>


More information about the Mercurial-devel mailing list