No from-import

[timeless]

Should there be a test-code for that?

On 1/5/12, Matt Mackall <mpm at selenic.com> wrote:
> On Wed, 2012-01-04 at 01:19 +0100, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>> # Date 1325098119 -3600
>> # Node ID 5bd197de486d13680484560fb56425bb503715ff
>> # Parent  371cff9610cdf6d6a7e1a6238ce75441b8107f03
>> phases: store phase values in constant instead of using raw integer
>>
>> Phases constant are named after the phase name. Usage of integer have been
>> replaced by proper constant.
>>
>> diff --git a/mercurial/context.py b/mercurial/context.py
>> --- a/mercurial/context.py
>> +++ b/mercurial/context.py
>> @@ -7,6 +7,7 @@
>>
>>  from node import nullid, nullrev, short, hex
>>  from i18n import _
>> +from phases import public, draft
>
> No "from" imports, please. You're not _, you're not important enough.
>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

-- 
Sent from my mobile device