[PATCH 3 of 9 phases] phases: add a phases command to display and manipulate phases

Matt Mackall mpm at selenic.com
Fri Jan 6 16:40:07 CST 2012


On Fri, 2012-01-06 at 06:50 +0100, Pierre-Yves David wrote:
> On Thu, Jan 05, 2012 at 10:04:39PM -0600, Matt Mackall wrote:
> > > +     ('r', 'rev', [], _('target revision')),
> > > +    ],
> > > +    _('[-p|-d|-s] [-f] [-C] [-r] [REV]'))
> > > +def phases(ui, repo, *revs, **opts):
> > > +    """set or show the current phase name
> > > +
> > > +    See :hg:`help phase-concept` for more information about phases if you are
> > > +    not familliar with this concept.
> > 
> > ENOENT, and an unlikely-to-be-approved name.
> 
> Any idea onabetterone name ? I needsomething that does not collide with the command itself.
> 
> Naming the commande "phase" and the help topic phases could do it.

I don't know, but my immediate point is that you shouldn't mention the
topic in the command help until the topic exists. It makes your patch
incomplete.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list