mercurial/crew at 15791: 13 outgoing changesets (3 stable)

Martin Geisler mg at aragost.com
Tue Jan 10 05:05:22 CST 2012


Matt Mackall <mpm at selenic.com> writes:

> On Mon, 2012-01-09 at 13:00 +0100, Mercurial Commits wrote:
>> 13 outgoing changesets (3 stable) in mercurial/crew:
>> 
>> http://hg.intevation.org/mercurial/crew/rev/a814f8fcc65a
>> changeset:   15791:a814f8fcc65a
>> tag:         tip
>> user:        Martin Geisler <mg at aragost.com>
>> date:        Sun Jan 08 18:15:54 2012 +0100
>> summary:     Use explicit integer division
>
> There's a bunch of stuff changed here which doesn't involve division?

Ups, sorry about that! I only meant to record the division changes. The
other changes fix other DeprecationWarnings thown when using the -3 flag
for the test suite. The

  __hash__ = object.__hash__

change in posix.py is harmless, but inconsequential on both platforms.
The

         self._lastnormaltime = 0

changes in dirstate fix a comparison between mixed types (NoneType and
int). That is allowed in Python 2.x, but for CPython this relies on a
weird semantics: the comparison is done based on the *name* of the type!

  http://docs.python.org/library/stdtypes.html#comparisons

So I think those changes are good, but the commit message is lacking.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://mercurial.aragost.com/kick-start/


More information about the Mercurial-devel mailing list