[PATCH 15 of 19] mq: use decorator to wrap writing commands with locks and automatic savedirty

Matt Mackall mpm at selenic.com
Sat Jan 14 15:43:15 CST 2012


On Fri, 2012-01-13 at 02:32 +0100, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <mads at kiilerich.com>
> # Date 1326245685 -3600
> # Node ID 8bccb99f4ff21f335503798db047cf27c79cd77c
> # Parent  342cbabf227347bd3cd65464ce9a19980df0be9b
> mq: use decorator to wrap writing commands with locks and automatic savedirty

An interesting notion, but I think this is probably too aggressive. This
is basically a poor man's "with" statement, except it's "with everything
for the whole function call".

For now, I think we should arrange for savedirty to get called
automatically when locks are released. If we want to get more clever
about taking and releasing locks, we should probably try to come up with
something more generally applicable.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list