[PATCH 1 of 1] Added branch line color and width setting to hgrc file

Constantine theaspect at gmail.com
Sun Jan 15 04:15:49 CST 2012


hg email --description filename sends description in another mail [patch 0
of 1]. This description satisfy guidelines. Should I change also commit
message?
Is this ok, if I split path in two pieces (width and color)
On Jan 15, 2012 12:25 PM, "Matt Mackall" <mpm at selenic.com> wrote:

> On Fri, 2012-01-13 at 00:06 +0700, Constantine Linnick wrote:
> > # HG changeset patch
> > # User Constantine Linnick <theaspect at gmail.com>
> > # Date 1326383329 -25200
> > # Node ID 585ccaf739dd30feba080e87162ce6e308c9a47d
> > # Parent  c47d69ce5208d5b5cfd2fb2f0f1d7a2b4795fbf5
> > Added branch line color and width setting to hgrc file
> > * * *
> > wrap
>
> This patch looks ok, but it's still running afoul of various patch
> submission guidelines.
>
> First, as I've hinted at a few times, I really just want one piece at a
> time:
>
> "At this point, Constantine should resend his original width patch
> adjusted to accept the above syntax."
>
> Please read the section about organizing patches in:
>
> http://mercurial.selenic.com/wiki/ContributingChanges#Organizing_patches
>
> We're really serious about one small change per patch. Send your width
> patch first, please.
>
> Also, your patch description is still not even close to the style I
> pointed you at for your very first patch:
>
> http://mercurial.selenic.com/wiki/ContributingChanges#Patch_descriptions
>
> Bullet points 1, 2, and 5 at least. Among other things, your description
> makes my automatic release summary generation script unhappy.
>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120115/650085ba/attachment.html>


More information about the Mercurial-devel mailing list