[PATCH phases] phases: ``hg phase`` command informs of phase movement

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Jan 17 13:18:24 CST 2012


On 17 janv. 2012, at 20:16, Matt Mackall wrote:

> On Tue, 2012-01-17 at 20:06 +0100, Pierre-Yves David wrote:
>>>> +            else:
>>>> +                ui.status(_('No phase movement\n'))
>>> 
>>> And this might want to be a warning.
>>> 
>>> You really love uppercase, don't you?
>>> 
>>> This should probably return 1.
>> 
>> hg push does return 0 when there is nothing to push. I kept the same logic here.
>> 
> 
> Who are you going to believe, hg push or me?

I'm highlighting the reason on my choice to be sure your didn't overlooked anything when you decide

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list