[PATCH 18 of 19] bookmarks: primarily use repo lock, not wlock

Matt Mackall mpm at selenic.com
Tue Jan 17 15:55:32 CST 2012


On Tue, 2012-01-17 at 23:21 +0200, Idan Kamara wrote:
> On Fri, Jan 13, 2012 at 3:32 AM, Mads Kiilerich <mads at kiilerich.com> wrote:
> 
> > # HG changeset patch
> > # User Mads Kiilerich <mads at kiilerich.com>
> > # Date 1326418243 -3600
> > # Node ID 87bc847a7ede54c4c1637e07d3ac31da08adb944
> > # Parent  d8fc79ea94e0c7179546af7c42ef02615770273a
> > bookmarks: primarily use repo lock, not wlock
> 
> 
> This broke two tests in python-hglib relating to bookmarks: test-summary
> and test-bookmarks.
> Haven't investigated yet so I'm not sure if it's related to cmdserver/hglib
> or to this actual change. My guess is it has something to do with the
> filecache.

Yeah, this patch is wrong. Bookmarks aren't stored in .hg/store.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list