[PATCH 2 of 9 phases] mq: have mq create secret changeset only

[Matt Mackall]

On Wed, 2012-01-18 at 00:37 +0100, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1326839603 -3600
> # Node ID 4470b206110b6004a42f086c0915695be0c3683a
> # Parent  353d1385f6ff36fafb291c8bf46474d9b17bfc7d
> mq: have mq create secret changeset only
> 
> diff --git a/hgext/mq.py b/hgext/mq.py
> --- a/hgext/mq.py
> +++ b/hgext/mq.py
> @@ -46,7 +46,7 @@
>  from mercurial.node import bin, hex, short, nullid, nullrev
>  from mercurial.lock import release
>  from mercurial import commands, cmdutil, hg, scmutil, util, revset
> -from mercurial import repair, extensions, url, error
> +from mercurial import repair, extensions, url, error, phases
>  from mercurial import patch as patchmod
>  import os, re, errno, shutil
>  
> @@ -251,6 +251,19 @@
>                  ci += 1
>              del self.comments[ci]
>  
> +def secretcommit(repo, *args, **kwargs):
> +    """helper dedicated to ensure a commit are secret
> +
> +    It should be used instead of repo.commit inside the mq source
> +    """
> +    bckdata = repo.ui.backupconfig('phases', 'new-commit')
> +    try:
> +        # ensure we won't create a secret changeset

Comment is backwards?

> +        repo.ui.setconfig('phases', 'new-commit', phases.secret)
> +        return repo.commit(*args, **kwargs)
> +    finally:
> +        repo.ui.restoreconfig(bckdata)

Unloved variable name.

-- 
Mathematics is the supreme nostalgia of our time.