[PATCH] graphlog: add special char for public and secret phases

Angel Ezquerra ezquerra at gmail.com
Wed Jan 18 12:28:54 CST 2012


On Jan 18, 2012 7:13 PM, "Kevin Bullock" <kbullock+mercurial at ringworld.org>
wrote:
>
> On Jan 18, 2012, at 11:05 AM, Pierre-Yves David wrote:
>
>> On Wed, Jan 18, 2012 at 04:57:58PM +0100, alain.leufroy at logilab.fr wrote:
>>>
>>> # HG changeset patch
>>>
>>> # User Alain Leufroy <alain.leufroy at logilab.fr>
>>>
>>> # Date 1326896559 -3600
>>>
>>> # Node ID 43bd418c215edf2a230b3420972a877509157e07
>>>
>>> # Parent  2642ac9d28d1375eb8ca92baafa05c02d59a84c6
>>>
>>> graphlog: add special char for public and secret phases
>>>
>>>
>>> diff -r 2642ac9d28d1 -r 43bd418c215e hgext/graphlog.py
>>>
>>> --- a/hgext/graphlog.py Tue Jan 17 11:08:23 2012 +0100
>>>
>>> +++ b/hgext/graphlog.py Wed Jan 18 15:22:39 2012 +0100
>>>
>>> @@ -298,7 +298,7 @@
>>>
>>> def generate(ui, dag, displayer, showparents, edgefn):
>>>
>>>     seen, state = [], asciistate()
>>>
>>>     for rev, type, ctx, parents in dag:
>>>
>>> -        char = ctx.node() in showparents and '@' or 'o'
>>>
>>> +        char = ctx.node() in showparents and '@' or 'Oo.'[ctx.phase()]
>>
>>
>> . is a terrible marker for a changeset :-/
>
>
> ...and O is too close to @ to be easily visually distinguishable. -1 on
this idea.
>
> pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
> Kevin R. Bullock
>

I think the idea is good. If phases are going to be in core mercurial, the
must be exposed to the user in done way!

We just need to choose better markers. Perhaps D for draft and S for
secret, leaving public revisions as the were?

Angel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120118/4d756dc6/attachment.html>


More information about the Mercurial-devel mailing list