Some initial impressions of phases

[Pierre-Yves David]

On Tue, Jan 24, 2012 at 02:29:31PM +0100, Jason Harris wrote:
> 
> On Jan 24, 2012, at 1:49 PM, Pierre-Yves David wrote:
> 
> > On Tue, Jan 24, 2012 at 12:48:55PM +0100, Jason Harris wrote:
> >> 
> >> On Jan 24, 2012, at 12:22 PM, Pierre-Yves David wrote:
> >>> On Tue, Jan 24, 2012 at 10:57:16AM +0100, Martin Geisler wrote:
> >>>> Jason Harris <jason at jasonfharris.com> writes:
> >>>>> On Jan 23, 2012, at 11:03 PM, Matt Mackall wrote:
> >>>>>>> Jason Harris <jason at jasonfharris.com> writes:
> >>>>>>> 
> >>>>>>> Point 11.
> >>>>>>> 
> >>>>>>> A local clone resets the phase to public. It shouldn't.
> >>>>>> 
> >>>>>> Debated elsewhere, many arguments pro and against exist.
> >>>>> 
> >>>>> Well, I believe it's going to cause problems in practice. Local clones
> >>>>> for experimentation are going to be hampered with having to manually
> >>>>> adjust the phase for each clone.
> >>>> 
> >>>> It was my understanding from the beginning that draft changesets are
> >>>> meant to be shared and that they were meant to be shared *as draft*.
> >>>> This is why I think they should remain drafts when you clone. Public
> >>>> servers can set publishing=True so that everything pushed there becomes
> >>>> public.
> >>> 
> >>> We already have a well defined concept to say "I wan't draft to stay draft":
> >>> 
> >>>   http://selenic.com/hg/rev/218ec96c45d7
> >> 
> >> Sorry maybe I missed it in reading that, but you meant "I want draft to stay draft" right?
> >> If so how do I do this?
> > 
> > yes s/wan't/want/
> > 
> >> Do you mean that if I set
> >> [phases]
> >> publish = 0
> >> 
> >> or publish =1, or publish = 2 in my hgrc then a local clone is meant to preserve the phase?
> >> If so this doesn't happen.
> > 
> > You read it wrong: You setting up a non-publishing repo using.
> > 
> > [phases]
> > publish=False
> > 
> >> Point 12:
> >> Note of course we should use private, draft, public, instead of 0, 1, 2.
> > 
> > But we use "true" and "false" (and other synonyms)
> 
> Actually I had made a mistake in my hgrc file. I had used [phase] like
> the command rather than [phases]. With setting:
> 
> [phases]
> publish=False
> 
> I can now do local clones which preserve phases!! That is **much** better. Thanks!
> 
> 
> >> Point 13:
> >> BTW for the documentation there is no help in the hgrc about phase.
> >> Eg 'hg help hgrc' doesn't mention anything about phase settings.
> > 
> > breaking news: Phase documentation is still a stumb and something to be heavily
> > working on during the freeze.  Any help is welcome on this side.
> 
> I got it the first time :) I am pointing out documentation bugs. (Note I can't fix them in any
> case even if I had the time (which I don't), since I don't know / understand phases
> in detail.)

Please considerer updating the last section of the wiki page to note all place
where you expected to find phaes documentations. It will help making sure we
don't miss any while writting that.

http://mercurial.selenic.com/wiki/PhasesDevel

> > Again. There *is* already a way. And there is already arguing on this topic.
> > Look at the commit description again.
> 
> 
> If you mean: http://selenic.com/hg/rev/218ec96c45d7 then that's really inadequate.

Inadequate ?

> But in any case, it means with an hgrc setting the user can preserve his/her phases
> when working with repositories locally! This should be displayed prominently in
> the documentation when it is written :)
> 
> That is one of the really big main sticking points I cared about. (Well that and
> documentation and some name choices... :)  (I can post a reduced list of which
> points I still think are problematic in light of the recent comments if you want...))

Could be a good idea, but make sure to point to existing discussions on such
point if they exists.

-- 
Pierre-Yves David

http://www.logilab.fr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120124/c05596d6/attachment.pgp>