push return code broken?

[John Coomes]

Matt Mackall (mpm at selenic.com) wrote:
> On Fri, 2012-01-27 at 18:26 +0100, Markus Zapke-Gründemann wrote:
> > Hi,
> > 
> > could it be that the return code of push is always zero? I created the
> > following test where the last push operation fails because it returns zero. But
> > push docs say "Returns 0 if push was successful, 1 if nothing to push.".
> 
> Yes, this seems to be a bug.

FWIW, I'd rather see the docs changed than the return code.  The
mirror command, pull, returns 0 if nothing was pulled:

    Returns 0 on success, 1 if an update had unresolved files.

-John