[PATCH 1 of 2] commit: ignore subrepos completely if the '.hgsub' is excluded via -X

[Jason Harris]

On Jan 28, 2012, at 1:20 AM, Matt Mackall wrote:

> On Fri, 2012-01-27 at 13:18 +0100, Jason Harris wrote:
>> However, instead of a dedicated setting to turn them off, I was pointing out a
>> place where we don't handle the -X option consistently. Ie -X .hgsub should act
>> like the .hgsub file wasn't there.
> 
> Except this is conceptually wrong. For the most part, the .hgsub file
> doesn't change, so is not subject to either inclusion or exclusion in
> commits. By adding this behavior, you're adding a _wholly new and
> nonstandard behavior for -X_.

> Again, the file of interest is .hgsubstate. If you don't want to commit
> subrepo state, then that definitionally means you don't want to
> commit .hgsubstate. Now problematically, this file is implicitly
> included by all commits that match one or more subrepos. A better
> solution would be -X 'set:subrepo()', but that predicate doesn't exist
> yet.
> 
> I definitely don't like the tunnel-through-an-undocumented-config-option
> approach. But let's put this discussion on hold until after Feb 1, as
> there's no way we're going to be able to do anything here this late in
> the cycle.

Cool... I have got various comments, but I'll bring them up after the
next release then...

Thanks,
  Jason