[PATCH] hgweb: support directory and subrepository navigation when descend mode is disabled

Matt Mackall mpm at selenic.com
Sun Jan 29 13:56:39 CST 2012


On Sun, 2012-01-29 at 20:45 +0100, Paul Boddie wrote:
> On Sunday 29 January 2012 20:25:38 Matt Mackall wrote:
> > On Sun, 2012-01-29 at 20:03 +0100, Paul Boddie wrote:
> > > # HG changeset patch
> > > # User Paul Boddie <paul at boddie.org.uk>
> > > # Date 1327863292 -3600
> > > # Branch stable
> > > # Node ID 967d0f22ee70762029beb539e15daf97b36ace86
> > > # Parent  f8955a7f82e6a06a682cd95631fd1c5e55f46103
> > > hgweb: support directory and subrepository navigation when descend mode
> > > is disabled
> >
> > a) it's not clear that this won't be a security surprise to existing
> > users
> 
> This shouldn't expose anything more than the directories and repositories 
> already exposed by hgweb. It isn't generic filesystem navigation; it's just 
> allowing people to group repositories inside directories and not have them 
> all shown at once at the first opportunity.

No, you've missed my point. If they aren't shown _today_, some people
will expect them to continue not being shown _tomorrow_. Thus changing
things is setting people up for a nasty surprise. 

But again: please hold this conversation until after Feb 1.

> > b) we're in the middle of the 2.1 code freeze, please resend after Feb 1
> > for discussion
> 
> Right. Sorry about that! I thought I'd kept on top of all the patch submission 
> requirements, but I imagine that I should have specified a flag somewhere.

If you send a patch that isn't appropriate for a freeze during the
freeze, it is inactionable. I delete inactionable mail immediately to
avoid my inbox growing unmanageable.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list