[PATCH 09 of 10] mq: mq.secret prevent mq changeset outside secret phase

[Matt Mackall]

On Mon, 2012-01-30 at 17:49 +0100, pierre-yves.david at logilab.fr wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at logilab.fr>
> # Date 1327941820 -3600
> # Branch stable
> # Node ID 440ddb63f450c1fc662517205bf4148529118f9e
> # Parent  44bfd92fa0f75504c460ef4c9f9fc28aca147a84
> mq: mq.secret prevent mq changeset outside secret phase
> 
> Any operation trying to put an mq changeset in a phase lower than draft will
> abort.

Wait, what? 

> +Test that mq.secret=true prevent to move mq changeset outside secret
phase
> +
> +  $ hg phase --draft qbase
> +  abort: cannot set mq changeset to draft with mq in secret mode
> +  (qfinish them or disable mq.secret)
> +  [255]

Ok, I guess.

> +  $ cp -r . ../remote
> +  $ hg -R ../remote qfinish qbase
> +  patch add-file1 finalized without changeset message
> +  $ hg pull ../remote # phase sync
> +  pulling from ../remote
> +  searching for changes
> +  no changes found
> +  abort: cannot set mq changeset to public with mq in secret mode
> +  (qfinish them or disable mq.secret)

It's not obvious to me that this is a good thing.

-- 
Mathematics is the supreme nostalgia of our time.