On reviewing "crew" (and possibly main) changes

Adrian Buehlmann adrian at cadifra.com
Mon Jul 2 03:37:01 CDT 2012


What's the procedure for reviewing crew changes?

I think I would appreciate if those pushing to crew would post their
patches on this list, preferrably --flag'ging their patches with "pushed
to crew" or something like that.

Currently, commenting on patches created by crew members and pushed by
crew members to crew, and then pulled into main is almost impossible.

On a related note, this could be extended to Matt himself and the main
repo, that is, to patches he creates himself and pushes to main
directly. If it's just to have a central place (the -devel mailing
list), where all relevant changes getting into Mercurial can be read.

As for Matt's own changes, there aren't that many anyway. But these are
often quite important. Demand to comment would certainly be the lowest
there, but it would still be informative to have one single place where
such changes can be read.

Comments on changes don't have to be of the form of blocking a change or
a critique. It might just make further discussions and awareness of
what's going on easier.

It would also be a good application of the "eat your own dogfood"
principle. The food being the requirement that changes should be
publicly posted on this list.

Perhaps the posting of such crew and main patches could be automated
with a push hook - or something like that.

I think merges and i18n changes could be excempt.


More information about the Mercurial-devel mailing list