[PATCH V2] test-largefiles: partially adapt for Windows

Matt Mackall mpm at selenic.com
Mon Jul 2 10:51:56 CDT 2012


On Mon, 2012-07-02 at 12:02 +0200, Adrian Buehlmann wrote:
> On 2012-07-02 01:52, Mads Kiilerich wrote:
> > Adrian Buehlmann wrote, On 06/30/2012 07:40 PM:
> >> # HG changeset patch
> >> # User Adrian Buehlmann <adrian at cadifra.com>
> >> # Date 1341077463 -7200
> >> # Node ID 327cc87b6f59c133172b36f3aa07bf9262c3070d
> >> # Parent  e1f2f7134ceda91ff08a203cad48f288c04238b3
> >> test-largefiles: partially adapt for Windows
> > 
> > Thanks, pushed to crew ...
> > 
> >> +MSYS on Windows doesn't support "rm -Rf ${USERCACHE}/*", so we define a
> >> +portable function instead
> >> +
> >> +  $ wipecache()
> >> +  > {
> >> +  >   find "${USERCACHE}" -mindepth 1 -print0 | xargs -0 rm -Rf
> >> +  > }
> > 
> > except for this. 'rm -Rf' works fine for me - especially if I quote the 
> > expanded variable.
> 
> Yeah. I see now that
> 
>   rm -Rf "${USERCACHE}"/*

Eep. If $USERCACHE fails to get set or gets unset...

Benoit can tell you a story about how a failing test nuked his laptop
several years ago.

I'd be happier if we simply did:

rm -rf "$USERCACHE"

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list