[PATCH 6 of 8] obsolete: compute extinct changesets
Augie Fackler
raf at durin42.com
Thu Jul 5 20:12:15 CDT 2012
On Jul 5, 2012, at 8:27 PM, Pierre-Yves David wrote:
A few English nits in the commit message, hopefully they're helpful.
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1341532651 -7200
> # Node ID d3e62e93711233bf43fee5ce2ea9e6cf2efccd4c
> # Parent c7470a6004a1146bdf4f47f1fd2f52fc9d54ca8f
> obsolete: compute extinct changesets
>
> `extinct` changesets are obsolete changesets with obsolete descendants only. They
> are of no interrest anymore and can be:
typo: s/interrest/interest/
>
> - exclude from exchange
> - hidden to the user in most situation
> - safely garbage collected
>
> This changeset just allow mercurial to detect them.
s/allow/allows/
>
> The implementation is a bit naive, as for unstable changesets. We better use a
s/better/should/
> simple revset query and a cache. But simple version goes first.
s/. B/, b/;s/goes/comes/
>
> diff --git a/mercurial/context.py b/mercurial/context.py
> --- a/mercurial/context.py
> +++ b/mercurial/context.py
> @@ -235,6 +235,21 @@
> return (self.node() in self._repo.obsstore.precursors
> and self.phase() > phases.public)
>
> + def extinct(self):
> + """True if the changeset is extinct"""
> + # We should just compute a cache a check agains it.
s/agains/against/
More information about the Mercurial-devel
mailing list