[PATCH] dirstate: eliminate redundant check parameter on _addpath()

Thomas Arendsen Hein thomas at intevation.de
Fri Jul 6 08:56:36 CDT 2012


* Adrian Buehlmann <adrian at cadifra.com> [20120706 13:03]:
> state == 'a' implies check
> 
> I fail to see what the point of this check parameter is. Near as I can see,
> the only _addpath call where it was set to True was in add(), but there, state
> is 'a'.
> 
> This is a follow-up to c2016bae3b97.

The patch is good, but a commit message with "I fail to see" might
not inspire confidence :)

The point of this check parameter is that it has been there in the
past (before c2016bae3b97) and nobody removed it yet.

Regards,
Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list