[PATCH] dirstate: eliminate redundant check parameter on _addpath()

Adrian Buehlmann adrian at cadifra.com
Fri Jul 6 09:13:41 CDT 2012


On 2012-07-06 15:56, Thomas Arendsen Hein wrote:
> * Adrian Buehlmann <adrian at cadifra.com> [20120706 13:03]:
>> state == 'a' implies check
>>
>> I fail to see what the point of this check parameter is. Near as I can see,
>> the only _addpath call where it was set to True was in add(), but there, state
>> is 'a'.
>>
>> This is a follow-up to c2016bae3b97.
> 
> The patch is good, but a commit message with "I fail to see" might
> not inspire confidence :)

Documenting my lack of confidence was intentional. Otherwise I would
have lied.

If I don't see why that check param is there, I might have missed
something. Of course I searched. But found nothing.

If I get confirmation that my finding is correct, then I can update the
change message and send a V2. Or whoever pushes the patch can remove
that paragraph.

> The point of this check parameter is that it has been there in the
> past (before c2016bae3b97) and nobody removed it yet.

Thanks for looking at this.


More information about the Mercurial-devel mailing list