[PATCH 5 of 6 v2] dirstate: speed up _addpath by switching from _dirs to _sortedfiles

Joshua Redstone joshua.redstone at fb.com
Mon Jul 9 09:57:24 CDT 2012



From: Kevin Bullock <kbullock+mercurial at ringworld.org<mailto:kbullock+mercurial at ringworld.org>>
Date: Tuesday, June 26, 2012 10:53 PM
To: Joshua Redstone <joshua.redstone at fb.com<mailto:joshua.redstone at fb.com>>
Cc: "mpm at selenic.com<mailto:mpm at selenic.com>" <mpm at selenic.com<mailto:mpm at selenic.com>>, "mercurial-devel at selenic.com<mailto:mercurial-devel at selenic.com>" <mercurial-devel at selenic.com<mailto:mercurial-devel at selenic.com>>
Subject: Re: [PATCH 5 of 6 v2] dirstate: speed up _addpath by switching from _dirs to _sortedfiles

+  $ touch z/b/c/d
+  $ hg add z/b/c/d
+  abort: directory 'z/b/c/d' already in dirstate
+  [255]
+

This looks like something that should be added _before_ switching to the new implementation, in a separate patch.

Good suggestion.  I've split off the tests into separate patches.


  $ cd ..

Issue1790: dirstate entry locked into unset if file mtime is set into
@@ -38,4 +53,3 @@
  $ hg debugstate
  n 644          2 2021-01-01 12:00:00 a
  $ cd ..
-

Unrelated whitespace change.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120709/2465d7ff/attachment.html>


More information about the Mercurial-devel mailing list