[PATCH 4 of 6 V2] localrepo: use the path relative to "self.vfs" instead of "path" argument

Matt Mackall mpm at selenic.com
Sun Jul 15 14:41:14 CDT 2012


On Sun, 2012-07-15 at 12:42 +0200, Adrian Buehlmann wrote:
> On 2012-07-06 11:45, FUJIWARA Katsunori wrote:
> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1341567927 -32400
> > # Node ID 7d07867c180e4189f27c60c56a05441d25aa4cc7
> > # Parent  df4490ac1e9a3cd4dca3a347869b45a24b9218b9
> > localrepo: use the path relative to "self.vfs" instead of "path" argument
> > 
> > As a part of migration to vfs, this patch uses "self.root", which can
> > be recognized as the path relative to "self.vfs", instead of "path"
> > argument.
> 
> ..
> 
> > This fix allows to make invocations of "util.makedirs()" and
> > "os.path.exists()" while ensuring repository directory in
> > "localrepository.__init__()" ones indirectly via vfs.
> 
> The grammar of this sentence is so crippled, that it makes no sense at
> all to me.

Yes, it's quite convoluted. But the patch itself is straightforward
enough that I couldn't be bothered trying to do anything about it,
especially given my backlog, the proximity of the freeze, my short
attention span due to back injury, and the lack of any timely interest
by anyone else in the 7 days this sat on the list. I probably could have
just deleted this sentence when queueing the patch and achieved an
acceptable result, so I don't think it matters.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list