[PATCH] zsh completion: catch up with Mercurial 2.3

[Matt Mackall]

On Mon, 2012-07-16 at 09:51 +0400, Nikolaj Sjujskij wrote:
> >>>> # HG changeset patch
> >>>> # User Nikolaj Sjujskij <sterkrig at myopera.com>
> >>>> # Date 1342342218 -14400
> >>>> # Node ID f28df36ee7debac14cd9af32929ed793e66deabb
> >>>> # Parent  3ac9592b7ab432e1470ec97d19c9b7c58c3fda86
> >>>> zsh completion: catch up with Mercurial 2.3
> >>>
> >>> To quote ContributingChanges:
> >>>
> >>> * patch does just one thing (if you need a bullet list, split your
> >>> patch)
> >>>
> >>> And boy does this ever have a bullet list.
> >>>
> >>> http://mercurial.selenic.com/wiki/OneChangePerPatch
> >>   Are you *really* sure you want patch per bullet?
> >
> > If someone sends you a URL to pages of guidelines they wrote on a
> > topic... it's probably to preempt your questions.
>   I have read (and re-read) those pages. And you seem not to have read my  
> objections for *this certain case*. So again:
> 1. It's a contrib/ thingy, not actual Mercurial codebase;
> 2. I don't think anybody would try bisecting zsh completion, since it's  
> mostly a list of options anyway.

If your argument is "but no one cares?"... why are you sending patches?
If it's worth sending a patch, it's worth doing right.

> If you want bullet-free patches, no problem (except for a few hours of my  
> time, of course). But then I'll have to send about 30 of them (yes, I've  
> just counted). It's almost half of all the changesets regarding zsh  
> completion in seven years. If that's what you want, so be it.

"In general, if your description of your change uses 'and' or includes a
bullet list of changes... you've probably got more than one change. On
the other hand, if you're doing some large but highly repetitive change
(eg "change all uses of repo.foo to repo.bar"), then that's an
acceptable single change."

I think you can get by with far fewer than 30 changes. For instance, all
the changes of the form "add a missing option switch with no additional
handling" can be in the same changeset. Those are trivial to review.

[backlog 65]

-- 
Mathematics is the supreme nostalgia of our time.