[PATCH 5 of 6 V2] peer: remove lock and addchangegroup from peer and restructure push

Matt Mackall mpm at selenic.com
Mon Jul 16 16:12:26 CDT 2012


On Fri, 2012-07-13 at 22:12 +0200, Sune Foldager wrote:
> # HG changeset patch
> # User Sune Foldager <cryo at cyanite.org>
> # Date 1342209203 -7200
> # Node ID 258587d53651fcd9088bd338fac667b9ecc19243
> # Parent  a5e5cf65a270907eca0e1249a2699b64b7a05d0d
> peer: remove lock and addchangegroup from peer and restructure push
> 
> The lock/addchangegroup code path for local remotes assumed no support for
> unbundle on localrepo/peer. This is now no longer the case.

This really doesn't look like a design win. If we were doing away with
lock on push entirely, great, let's do this. But I don't see that we're
going to drop push locking on local peers or ssh.. ever. So this just
makes things a bit uglier.

I've queued patches 1-4 for default, thanks.

[backlog 40]

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list