Need guidance wrt [Bug 3550]: Keyword extension break large file support

[Christian Ebert]

Hi,

I am writing to the list because I need assistance with this one
due to time constraints.

Basically the 2 incarnations of commitctx in largefiles and
keyword outrule each other.

If I am given time, I can

1) implement a decent error which tells the user about the
current state that the keyword and largefiles extensions cannot
be used together

2) hopefully change the current state and make them work together

But realistically I cannot escape my extremely stressful schedule
for the next few weeks - as much as I'd like to.

Depending on how urgent this is deemed, it might need some
drastical measures.

c



----- Forwarded message from bugzilla-daemon at bz.selenic.com -----

From: bugzilla-daemon at bz.selenic.com
Date: Mon, 23 Jul 2012 12:11:55 +0000
Subject: [Bug 3550] New: Keyword extension break large file support
To: blacktrash at gmx.net

http://bz.selenic.com/show_bug.cgi?id=3550

          Priority: normal
            Bug ID: 3550
                CC: blacktrash at gmx.net
          Assignee: bugzilla at selenic.com
           Summary: Keyword extension break large file support
          Severity: bug
    Classification: Unclassified
                OS: Windows
          Reporter: guido.jansen at lmsintl.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: 2.2.3
         Component: keyword
           Product: Mercurial

The keyword extension breaks largefile support. The scenario below no longer
works. It should create a file in C:\TEMP\largefiletest\.hg\largefiles that
represents the largefile. Disabling the keyword extension makes this work
again.


hg --version
Mercurial Distributed SCM (version 2.2.3)
(see http://mercurial.selenic.com for more information)

Copyright (C) 2005-2012 Matt Mackall and others
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Problem is in keyword.py, line 584:
  self.commitctx = self.kwcommitctx

This prevents the commitctx override from the largefile extension to be called.
The check in largefile extension is not catching. See largefiles/reposetup.py
line 283 for the method commitctx and line 28 for the check if there is a
conflict.


Guido



cd C:\temp\largefiletest
hg init
touch somelargefile
hg add --large somelargefile
hg commit -m PR=1

dir C:\TEMP\largefiletest\.hg\largefiles
 Volume in drive C has no label.
 Volume Serial Number is 6198-0000

 Directory of C:\TEMP\largefiletest\.hg\largefiles

07/23/2012  01:48 PM    <DIR>          .
07/23/2012  01:48 PM    <DIR>          ..
07/23/2012  01:48 PM                70 dirstate
               1 File(s)             70 bytes
               2 Dir(s)  24,374,206,464 bytes free

-- 
You are receiving this mail because:
You are on the CC list for the bug.

----- End forwarded message -----

-- 
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions