[PATCH] localrepo: clear the filecache on _rollback() and destroyed()

[Greg Ward]

On 28 July 2012, Idan Kamara said:
> # HG changeset patch
> # User Idan Kamara <idankk86 at gmail.com>
> # Date 1343504430 -10800
> # Branch stable
> # Node ID b4aefebff45caa66ca253c43a673b5847a2b84a6
> # Parent  a09cc6aeed4a6d54a3846b6653165fd3b328d1ef
> localrepo: clear the filecache on _rollback() and destroyed()
> 
> This restores the old behaviour of clearing the filecache when the repo is
> destroyed but combines it with also clearing it on _rollback. Before, we tried
> to only call it through _rollback but that ruined callers of destroyed.
> 
> Doing it on both code paths covers destroyed being called from somewhere
> else, e.g. strip.

I'm confused. We introduced localrepository.destroyed() so there would
be only *one* code path to follow when changesets are destroyed,
whether by strip or by rollback. So any operation that needs to take
place when changesets are destroyed belongs in destroyed().

It's unclear what you're fixing here.

       Greg
-- 
Greg Ward                                http://www.gerg.ca/
There's nothing to see here.  Move on; go about your business.