[PATCH 5 of 6 stable] hgweb: avoid traceback when comparing a non-existent file

Ross Lagerwall rosslagerwall at gmail.com
Mon Jul 30 07:47:09 CDT 2012


On 07/30/2012 01:30 PM, Patrick Mézard wrote:
> Excellent, thank you. I pushed all the patches but this one to crew-stable, after updating the tests:
> 

Ah, I forgot about the tests. Thanks.

> About this patch, I have not looked at the code yet but is there no way to make it fail earlier without removing the generator? Does the diff page have the same problem? What are the (performance?) implications of removing the generator?
> 
The diff page does indeed fail earlier (i.e. works correctly).
I would think that using the generator or not would give pretty similar
performance.
In any case, I see that the doc comment would need to be changed if the
generator were not used.

As the author of the code, let's see what Wujek Srujek says (CC'ing).

-- 
Ross Lagerwall

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120730/a96695f6/attachment.pgp>


More information about the Mercurial-devel mailing list