[PATCH STABLE] setup: fix build_hgexe for mingw32 compiler

[Adrian Buehlmann]

On 2012-07-30 15:29, Mads Kiilerich wrote:
> On 26/07/12 17:42, Adrian Buehlmann wrote:
>> On 2012-07-26 08:06, Adrian Buehlmann wrote:
>>> On 2012-07-26 02:35, Mads Kiilerich wrote:
>> [..]
>>>> It seems like
>>>> it is touching a long lived 'compiler' instance
>>> Does it? I thought that this was a separate invocation anyway.
>>>
>>> But it could well be that I made an error here, without beeing affected
>>> by the (suspected) bad consequences.
>>>
>>>> and the change is thus not necessarily local anyway.
>>> That would be bad indeed. I'll look into that.
>> I can't find anything fishy with bf5bb38bcc7c.
>>
>> I even tried
>>
>>    $ C:\Python27_x86\python.exe setup.py build_ext -i --compiler=mingw32 build_hgexe -i --compiler=mingw32
>>
>> and
>>
>>    $ C:\Python27_x86\python.exe setup.py build_hgexe -i --compiler=mingw32 build_ext -i --compiler=mingw32
>>
>> I get a perfectly fine working hg.exe and mercurial/*.pyd files
>> in both cases.
> 
> I'm not saying that it doesn't work after your change. I'm just 
> wondering what the story is. Reviewing and brief testing with 2.6 made 
> it look like some of the changes are unnecessary hacks and it is unclear 
> what problem they solve and why it is a good solution.

I wrote in this thread what problem they solved. Did you even read it?

> The parts of the
> patch that I found necessary worked equally well when done in 
> HackedMingw32CCompiler. 2.6 might however be different from 2.7.

[..]

> It might thus be hard to maintain this change if problems should pop up. 
> But ok, we don't need detailed commit messages as long as you are around 
> to fix any problems that might show up ;-)

Well. So you are saying now it is a problem with the commit message?