[PATCH] test-commit-amend: enable for Windows

Mads Kiilerich mads at kiilerich.com
Fri Jun 1 10:02:39 CDT 2012


On 01/06/12 15:55, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann<adrian at cadifra.com>
> # Date 1338558610 -7200
> # Node ID d150682d23d561f4f4867bea4335adb91fdd396c
> # Parent  68e40966bda5e2196bbaf9400a59236f222b3658
> test-commit-amend: enable for Windows
>
> diff --git a/tests/test-commit-amend.t b/tests/test-commit-amend.t
> --- a/tests/test-commit-amend.t
> +++ b/tests/test-commit-amend.t
> @@ -1,5 +1,3 @@
> -  $ "$TESTDIR/hghave" execbit || exit 80
> -
>     $ hg init
>
>   Setup:
> @@ -29,7 +27,7 @@
>
>     $ echo a>>  a
>     $ hg ci --amend -m 'amend base1'
> -  saved backup bundle to $TESTTMP/.hg/strip-backup/489edb5b847d-amend-backup.hg
> +  saved backup bundle to $TESTTMP/.hg/strip-backup/*-backup.hg (glob)

Did the hash change? Should it?

There is a little bit of value in testing that the same hashes always 
are used on all platforms. Testing it everywhere might be a bit 
overkill, but globbing it just to avoid testing it might be even more 
overkill.

Btw: The tests are run with ui.slash=True, so arguably it is a bug that 
hg emit backslashed paths at all ...

/Mads



More information about the Mercurial-devel mailing list