[PATCH] test-commit-amend: enable for Windows
Adrian Buehlmann
adrian at cadifra.com
Fri Jun 1 11:00:00 CDT 2012
On 2012-06-01 17:02, Mads Kiilerich wrote:
> On 01/06/12 15:55, Adrian Buehlmann wrote:
>> # HG changeset patch
>> # User Adrian Buehlmann<adrian at cadifra.com>
>> # Date 1338558610 -7200
>> # Node ID d150682d23d561f4f4867bea4335adb91fdd396c
>> # Parent 68e40966bda5e2196bbaf9400a59236f222b3658
>> test-commit-amend: enable for Windows
>>
>> diff --git a/tests/test-commit-amend.t b/tests/test-commit-amend.t
>> --- a/tests/test-commit-amend.t
>> +++ b/tests/test-commit-amend.t
>> @@ -1,5 +1,3 @@
>> - $ "$TESTDIR/hghave" execbit || exit 80
>> -
>> $ hg init
>>
>> Setup:
>> @@ -29,7 +27,7 @@
>>
>> $ echo a>> a
>> $ hg ci --amend -m 'amend base1'
>> - saved backup bundle to $TESTTMP/.hg/strip-backup/489edb5b847d-amend-backup.hg
>> + saved backup bundle to $TESTTMP/.hg/strip-backup/*-backup.hg (glob)
>
> Did the hash change?
No.
> Should it?
No.
> There is a little bit of value in testing that the same hashes always
> are used on all platforms. Testing it everywhere might be a bit
> overkill, but globbing it just to avoid testing it might be even more
> overkill.
But it has been done on other tests already.
> Btw: The tests are run with ui.slash=True, so arguably it is a bug that
> hg emit backslashed paths at all ...
So do we need to fix this right now or can we run the test on Windows as is?
More information about the Mercurial-devel
mailing list