[PATCH RFC] parsers: add a C function to pack the dirstate

[Adrian Buehlmann]

On 2012-06-07 02:21, Bryan O'Sullivan wrote:
> On Wed, Jun 6, 2012 at 4:38 PM, Adrian Buehlmann <adrian at cadifra.com
> <mailto:adrian at cadifra.com>> wrote:
> 
>     You have now resent this patch a couple of times. It is a very difficult
>     to review patch.
> 
> 
> It's actually very easy, once you're familiar with the Python C API.
> Granted, it's pretty intimidating otherwise.

I have to read up on almost every function documentation. The code by
itself is not really intimidating but its IMHO still pretty easy to make
bugs.

I still have parsers.c on my list for cleaning up compiler warnings, but
the reviewers are currently on strike / swamped anyway :-)

BTW, regarding parsers.c: stack-based local vars of type "long" are a
bit a problem on Windows. These are only 32 bit on Windows. So, in
theory, assigning Py_ssize_t's to these can be problematic.

> 
>     The question is: what have you changed for this version?
> 
> 
> Nothing, I actually resent it by accident.

Oh. And I thought you wanted more attention with the RFC flag.